Reject shrinking disk during YAML validation #3596
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR implements early YAML validation to reject configurations that attempt to shrink the disk size rather than waiting until instance startup.
- Added a ValidateYAMLAgainstLatest function that compares disk sizes from the new and latest YAML configurations.
- Integrated the new validation into the limactl edit flow to save and report rejected configurations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pkg/limayaml/validate.go | Added a YAML validation function to prevent disk size shrinking. |
| cmd/limactl/edit.go | Integrated validation into the edit command and added a function to handle rejected YAML. |
songponssw
force-pushed
the
reject-shrinking-disk
branch
2 times, most recently
from
4532c86 to
4f4a7c1
Compare
|
The disk value can be |
songponssw
force-pushed
the
reject-shrinking-disk
branch
from
ecf31d3 to
bbb1a66
Compare
|
Please squash and sign off the commits |
|
Got it! However, I noticed some unexpected behavior when no disk size is specified. The generated YAML doesn't include the disk field, causing this function to return nil. I'm not sure whether we should inject the default disk size into the YAML when creating the new instance, or handle it another way. |
Signed-off-by: Songpon Srisawai <songpon.ssw@gmail.com> Co-authored-by: Jan Dubois <jan@jandubois.com>
songponssw
force-pushed
the
reject-shrinking-disk
branch
from
bbb1a66 to
4ef46c4
Compare
As @jandubois suggested in #3533.
Currently, rejecting shrinking disk size happens during instance startup.
This PR adds validation earlier during YAML validation.
The function compares values between the new config and the latest config YAML files to reject disk size shrinking during validation.